Repository navigation
feat: add Google Cloud OIDC detector - #306
Merged
Merged
Conversation
cloudsmith-iduffy
marked this pull request as draft
June 8, 2026 22:57
cloudsmith-iduffy
force-pushed
the
iduffy/gcp-oidc
branch
from
June 8, 2026 23:01
e894eff to
c80922f
Compare
cloudsmith-iduffy
force-pushed
the
iduffy/gcp-oidc
branch
6 times, most recently
from
June 10, 2026 14:06
e8c47d0 to
d8816e1
Compare
cloudsmith-iduffy
force-pushed
the
iduffy/gcp-oidc
branch
3 times, most recently
from
June 10, 2026 20:26
60f4060 to
ceeb715
Compare
cloudsmith-iduffy
changed the base branch from
master
to
iduffy/oidc-detector-controls
June 10, 2026 20:26
cloudsmith-iduffy
force-pushed
the
iduffy/gcp-oidc
branch
3 times, most recently
from
September 29, 2026 11:20
ebd441a to
c964cf7
Compare
cloudsmith-iduffy
marked this pull request as ready for review
September 29, 2026 11:22
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Incompatible user ADC can shadow a valid generic OIDC token and cause authentication to fail.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds optional Google Cloud OIDC authentication through Application Default Credentials.
Changes:
- Adds the GCP detector, dependency extra, and registration.
- Supports metadata, IAM fallback, service-account, impersonated, and user credentials.
- Adds tests and user documentation.
| File | Description |
|---|---|
uv.lock |
Locks Google authentication dependencies. |
README.md |
Documents GCP OIDC setup and behavior. |
pyproject.toml |
Adds gcp and updates all extras. |
cloudsmith_cli/core/tests/test_generic_detector.py |
Accounts for GCP detector precedence. |
cloudsmith_cli/core/tests/test_gcp_detector.py |
Tests GCP detection and token flows. |
cloudsmith_cli/core/credentials/oidc/detectors/gcp.py |
Implements the GCP detector. |
cloudsmith_cli/core/credentials/oidc/detectors/__init__.py |
Registers GCP in detector order. |
CHANGELOG.md |
Records the new feature. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tigh-latte
approved these changes
Oct 5, 2026
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: cloudsmith-iduffy <178375997+cloudsmith-iduffy@users.noreply.github.com>
Co-authored-by: cloudsmith-iduffy <178375997+cloudsmith-iduffy@users.noreply.github.com>
cloudsmith-iduffy
force-pushed
the
iduffy/gcp-oidc
branch
from
October 5, 2026 17:47
632c395 to
a6a5225
Compare
Contributor
Resolved the conflicts by merging |
tigh-latte
added a commit
that referenced
this pull request
Oct 7, 2026
This reverts commit ce23961.
tigh-latte
added a commit
that referenced
this pull request
Oct 7, 2026
This reverts commit f194d83.
tigh-latte
added a commit
that referenced
this pull request
Oct 7, 2026
This reverts commit f194d83.
tigh-latte
added a commit
that referenced
this pull request
Oct 8, 2026
* Reapply "feat: add Buildkite OIDC credential detection (#415)" This reverts commit 3b5c328. * Reapply "feat: add Google Cloud OIDC detector (#306)" This reverts commit f194d83. * Potential fix for pull request finding 'Add Buildkite OIDC detector to the changelog' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Google Cloud OIDC authentication through
cloudsmith-cli[gcp].generateIdTokenwhen the metadata identity endpoint returns 404; requiresiam.serviceAccounts.getOpenIdToken.Validation
google-10rfiniduffy-demoand listed repositories successfully.